Re: [ratchov/sndio] configure: Add check for linux-generic is already the newest version … (PR #3)

On Fri, Sep 23, 2022 at 12:30:22AM -0700, Gianfranco Costamagna wrote:
> BTW I don't think its a sane idea to bundle libbsd, we should by default use
> the system version whenever possible.
> 
> e.g. on amd64
> x86_64-linux-gnu-gcc -g -O2 -ffile-prefix-map=/<>=. -fstack-protector-strong
> -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I../
> bsd-compat -DDEBUG -D_GNU_SOURCE -DHAVE_SOCK_CLOEXEC -DHAVE_CLOCK_GETTIME
> -DUSE_ALSA -DUSE_LIBBSD -DHAVE_STRLCPY -DHAVE_STRLCAT -DHAVE_STRTONUM -c -o
> getpeereid.o ../bsd-compat/getpeereid.c
> x86_64-linux-gnu-gcc -g -O2 -ffile-prefix-map=/<>=. -fstack-protector-strong
> -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I../
> bsd-compat -DDEBUG -D_GNU_SOURCE -DHAVE_SOCK_CLOEXEC -DHAVE_CLOCK_GETTIME
> -DUSE_ALSA -DUSE_LIBBSD -DHAVE_STRLCPY -DHAVE_STRLCAT -DHAVE_STRTONUM -c -o
> issetugid.o ../bsd-compat/issetugid.c
> x86_64-linux-gnu-gcc -g -O2 -ffile-prefix-map=/<>=. -fstack-protector-strong
> -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I../
> bsd-compat -DDEBUG -D_GNU_SOURCE -DHAVE_SOCK_CLOEXEC -DHAVE_CLOCK_GETTIME
> -DUSE_ALSA -DUSE_LIBBSD -DHAVE_STRLCPY -DHAVE_STRLCAT -DHAVE_STRTONUM -c -o
> strlcat.o ../bsd-compat/strlcat.c
> x86_64-linux-gnu-gcc -g -O2 -ffile-prefix-map=/<>=. -fstack-protector-strong
> -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I../
> bsd-compat -DDEBUG -D_GNU_SOURCE -DHAVE_SOCK_CLOEXEC -DHAVE_CLOCK_GETTIME
> -DUSE_ALSA -DUSE_LIBBSD -DHAVE_STRLCPY -DHAVE_STRLCAT -DHAVE_STRTONUM -c -o
> strlcpy.o ../bsd-compat/strlcpy.c
> x86_64-linux-gnu-gcc -g -O2 -ffile-prefix-map=/<>=. -fstack-protector-strong
> -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I../
> bsd-compat -DDEBUG -D_GNU_SOURCE -DHAVE_SOCK_CLOEXEC -DHAVE_CLOCK_GETTIME
> -DUSE_ALSA -DUSE_LIBBSD -DHAVE_STRLCPY -DHAVE_STRLCAT -DHAVE_STRTONUM -c -o
> strtonum.o ../bsd-compat/strtonum.c
> x86_64-linux-gnu-gcc -g -O2 -ffile-prefix-map=/<>=. -fstack-protector-strong
> -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I../
> bsd-compat -DDEBUG -D_GNU_SOURCE -DHAVE_SOCK_CLOEXEC -DHAVE_CLOCK_GETTIME
> -DUSE_ALSA -DUSE_LIBBSD -DHAVE_STRLCPY -DHAVE_STRLCAT -DHAVE_STRTONUM -c -o
> clock_gettime.o ../bsd-compat/clock_gettime.c
> 
> all of them should be provided by libbsd, right?
> 

IIRC few functions were missing when bsd-compat/ was introduced. If
all functions all part of libbsd and libbsd is available on all
distros, we should just drop the whole bsd-compat/ directory.

(Cc:'ing the mailing list, as most of the maintainers are there.)