Re: Build on master fails

From: Alexandre Ratchov <alex_at_caoua.org>
Date: Fri, 29 Oct 2021 12:57:56 +0200
On Fri, Oct 29, 2021 at 04:07:24PM +0530, Avinash Sonawane wrote:
> Hello!
> 
> I'm trying to compile sndio source.
> 
> I get these errors:
> ```
> ./configure --enable-alsa --enable-rmidi --enable-umidi --with-libbsd
> --enable-oss
> $ make -j4
> ...
> sio_oss.c:69:4: error: use of undeclared identifier 'AFMT_U24_BE'
>         { AFMT_U24_BE, 24, 3, 0, 0, 0 },
>           ^
> sio_oss.c:71:4: error: use of undeclared identifier 'AFMT_U24_LE'
>         { AFMT_U24_LE, 24, 3, 0, 1, 0 },
>           ^
> sio_oss.c:76:4: error: use of undeclared identifier 'AFMT_U32_BE'
>         { AFMT_U32_BE, 32, 4, 0, 0, 1 },
>           ^
> sio_oss.c:77:4: error: use of undeclared identifier 'AFMT_U32_LE'
>         { AFMT_U32_LE, 32, 4, 0, 1, 1 },
>           ^
> ...
> ```
> 
> Looking at the OSS source it seems there are no formats named
> AFMT_U24_BE, AFMT_U24_LE, AFMT_U32_BE and AFMT_U32_LE.
> 
> I simply removed those and the build completed successfully.
> 
> I've attached the patch. Though I'm sot sure if this is the correct
> way...

Hi,

Is this Linux? If so, please don't use --enable-oss, the OSS backend
is specific to FreeBSD, so other parts may fail too.

Anyway, AFMT_{U24,U32}_xx could be removed as you suggest.

I've never seen hardware that supports unsigned 24-bit samples but
doesn't support signed 24-bit samples. Such hardware probably doesn't
exist.  My guess is that the AFMT_U24_xxx and AFMT_U32_xxx constants
were added for completeness but are not used at all.

But, I'd like to hear opinions of FreeBSD users before removing
AFMT_U24 and AFMT_U32 support.
Received on Fri Oct 29 2021 - 12:57:56 CEST

This archive was generated by hypermail 2.3.0 : Sat Oct 30 2021 - 01:36:09 CEST