Re: Look up table generation

From: Alexandre Ratchov <alex_at_caoua.org>
Date: Fri, 29 Jan 2021 10:57:58 +0100
On Fri, Jan 29, 2021 at 01:29:51AM -0300, …rico Nogueira wrote:
> > 
> > > Furthermore, would you be interested in patches to try and decrease the
> > > amount of duplicated code between aucat/ and sndiod/, if it doesn't prove
> > > too complicated to do?
> > > 
> > > [1] https://github.com/ratchov/sndio/commit/2996dcdc03e872c1534c15750a9f741c6afffbc0
> > > 
> > 
> > Indeed dec_{mulaw,alaw,float}() could go in their own file leaving
> > dsp.c almost the same. AFAICS, sndiod resampling bits are just a
> > special case of aucat one (aucat needs to work with partial blocks
> > while sndiod doesn't), so sndiod could be switched to use aucat
> > resampler leaving both dsp.c the same.
> > 
> > For the Makefile tweakery to use a common source file we need to
> > involve OpenBSD devs. But even if we don't go this way, reducing
> > differences is always welcome
> 
> Do you think an internal libsndio-internal.a would make the OpenBSD part any
> easier? Otherwise I can stick with removing differences between the two
> files (or duplicating them exactly).
> 

I don't know what's is the best approach; sndio is a tiny piece of
code in the very large OpenBSD code base. Let's first see how others
handle this and keep the code base uniform. I bet there are other
sub-projets that have to deal with common files, probably ssh and
smtpd do so.

In any case removing the differences is a step forward
Received on Fri Jan 29 2021 - 10:57:58 CET

This archive was generated by hypermail 2.3.0 : Sat Jan 30 2021 - 01:33:56 CET